diff --git a/CHANGELOG.md b/CHANGELOG.md index d658852..bd04fde 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,12 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). +## Unreleased + +### Fixed + +- Added support for undocumented panel orientation 'EastWest' [#131](https://github.com/pyrocumulus/pvoutput.net/pull/131) - Contribution [CodeCasterNL](https://github.com/CodeCasterNL) + ## [0.11.0] - 2022-05-05 ### Changed diff --git a/src/PVOutput.Net/Enums/Orientation.cs b/src/PVOutput.Net/Enums/Orientation.cs index beeb871..807c4a7 100644 --- a/src/PVOutput.Net/Enums/Orientation.cs +++ b/src/PVOutput.Net/Enums/Orientation.cs @@ -56,6 +56,12 @@ public enum Orientation /// NorthWest /// [Description("NW")] - NorthWest = 7 + NorthWest = 7, + + /// + /// EastWest + /// + [Description("EW")] + EastWest = 8 } } diff --git a/tests/PVOutput.Net.Tests/Modules/System/SystemServiceTests.cs b/tests/PVOutput.Net.Tests/Modules/System/SystemServiceTests.cs index c7e7984..d74e5c7 100644 --- a/tests/PVOutput.Net.Tests/Modules/System/SystemServiceTests.cs +++ b/tests/PVOutput.Net.Tests/Modules/System/SystemServiceTests.cs @@ -111,7 +111,7 @@ public async Task SystemReader_OwnSystemWithoutSecondaryPanelResponse_CreatesCor Assert.That(result.NumberOfInverters, Is.EqualTo(1)); Assert.That(result.InverterPower, Is.EqualTo(5500)); Assert.That(result.InverterBrand, Is.EqualTo("Fronius Primo 3.6-1")); - Assert.That(result.Orientation, Is.EqualTo(Orientation.East)); + Assert.That(result.Orientation, Is.EqualTo(Orientation.EastWest)); Assert.That(result.ArrayTilt, Is.EqualTo(53.0m)); Assert.That(result.Shade, Is.EqualTo(Shade.None)); Assert.That(result.InstallDate, Is.Null); diff --git a/tests/PVOutput.Net.Tests/Modules/System/SystemSystemTestsData.cs b/tests/PVOutput.Net.Tests/Modules/System/SystemSystemTestsData.cs index 7b4af11..e6c6d6e 100644 --- a/tests/PVOutput.Net.Tests/Modules/System/SystemSystemTestsData.cs +++ b/tests/PVOutput.Net.Tests/Modules/System/SystemSystemTestsData.cs @@ -8,7 +8,7 @@ public partial class SystemServiceTests public const string SYSTEM_RESPONSE_SIMPLE = "Test System,4125,1234,15,275,JA Solar mono,1,5500,Fronius Primo 3.6-1,E,,No,,51.0,6.1,5;;"; - public const string OWNSYSTEM_RESPONSE_WITHOUT_SECONDARYPANEL = "Test System,4125,1234,15,275,JA Solar mono,1,5500,Fronius Primo 3.6-1,E,53.0,No,,51.0,6.1,5,,,null,NaN;"; + public const string OWNSYSTEM_RESPONSE_WITHOUT_SECONDARYPANEL = "Test System,4125,1234,15,275,JA Solar mono,1,5500,Fronius Primo 3.6-1,EW,53.0,No,,51.0,6.1,5,,,null,NaN;"; public const string SYSTEM_RESPONSE_EXTENDED = "Test System,4125,1234,15,275,JA Solar mono,1,5500,Fronius Primo 3.6-1,E,53.1,No,20160822,51.0,6.1,5,10,190,W,33.5;17.37,20.46,20.2,25.4,22.65,40.0;12,232,480,512;1;DC-1 Voltage,V,DC-2 Voltage,V,DC-DC Booster Temp,°C,DC-1 Power (2x13x290Wp),W;61,106,252,380,430,425,417,354,253,159,70,48,400,350,300,250,200,150,100,175,275,375,475,525";