Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plated samples are incompatible with Pyro api #273

Open
fritzo opened this issue Oct 12, 2019 · 0 comments
Open

Plated samples are incompatible with Pyro api #273

fritzo opened this issue Oct 12, 2019 · 0 comments

Comments

@fritzo
Copy link
Member

fritzo commented Oct 12, 2019

One issue with funsor.minipyro is that the samples returned from a model are not compatible with tensor shapes and numpy shapes. This came up in pyro-ppl/pyro-api#5 as we try to create a generic API for multiple Pyro backends.

One solution might be to add a to_tensor() method for model results.

Another solution might be to start using named tensors or an align-like method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant