Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dragging elements from sidebar #5

Open
AlecAivazis opened this issue May 7, 2019 · 3 comments
Open

Dragging elements from sidebar #5

AlecAivazis opened this issue May 7, 2019 · 3 comments
Labels

Comments

@AlecAivazis
Copy link
Collaborator

AlecAivazis commented May 7, 2019

This issue should act as the central location for discussion on dragging new elements from the sidebar.

In the current implementation (as of 5/7/2019) no mutations are sent to the API until the user stops dragging the shadow and drops it on the diagram. At that point, the client selects the element that is created allowing the user to customize it.

@AlecAivazis
Copy link
Collaborator Author

@aivazis do you want the factory shadow to show just the central diamond or the compact view? The original design shows the diamond, but I think we decided to show the full factory so the user could drop it with confidence they aren't disturbing their diagram. Is that correct?

@aivazis
Copy link
Member

aivazis commented May 7, 2019

i think the compact view is preferable

@AlecAivazis
Copy link
Collaborator Author

AlecAivazis commented May 22, 2019

@aivazis I spent some time today/yesterday exploring whether we needed separate types for the shadows. While it does overload the semantics of Factory, Im pretty sure the fields are almost entirely the same so i think the shortest path (and possibly even the "right" one) is to just have a single type that represents both FactoryPrototypes and FactoryInstances

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants