Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LICENSE.txt is missing in latest pypi release #371

Closed
priv-kweihmann opened this issue Aug 19, 2020 · 9 comments
Closed

LICENSE.txt is missing in latest pypi release #371

priv-kweihmann opened this issue Aug 19, 2020 · 9 comments

Comments

@priv-kweihmann
Copy link

but it was present in 0.34.2 release - please add it again

@agronholm
Copy link
Contributor

This is weird. Running python setup.py sdist manually produces an sdist with LICENSE.txt included, but it's missing from the published sdist.

@agronholm
Copy link
Contributor

Even using the exact same version of setuptools makes no difference. The license file is still there when I create the sdist locally.

@agronholm
Copy link
Contributor

The file is definitely present because it's in the published wheel! Just not the sdist.

@priv-kweihmann
Copy link
Author

Okay - I was just checking the sdist, as this is what I build at the moment

@agronholm
Copy link
Contributor

Seems like this happened again with the latest release. If you could reproduce it locally, that would help. I cannot reproduce it here.

@priv-kweihmann
Copy link
Author

priv-kweihmann commented Dec 1, 2020

@agronholm
Copy link
Contributor

Yes, like I said. The only difference in the logs on CI is that LICENSE.txt is not copied. All the other files are. I cannot understand what could be causing this, or how to reproduce it locally.

@priv-kweihmann
Copy link
Author

No idea to be honest - but I don't see any line matching the LICENSE.txt in https://github.com/pypa/wheel/blob/master/MANIFEST.in

@agronholm
Copy link
Contributor

Yet it's always added to the sdist locally here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants