Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade embeded setuptools #1855

Merged
merged 2 commits into from
Jun 12, 2020
Merged

Upgrade embeded setuptools #1855

merged 2 commits into from
Jun 12, 2020

Conversation

gaborbernat
Copy link
Contributor

No description provided.

@gaborbernat
Upgrade embeded setuptools
9327e07 
Signed-off-by: Bernat Gabor <[email protected]>
@codecov
Copy link

codecov bot commented Jun 12, 2020 •
edited
Loading

Codecov Report

Merging #1855 into master will decrease coverage by 3.82%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1855      +/-   ##
==========================================
- Coverage   88.84%   85.02%   -3.83%     
==========================================
  Files          82       82              
  Lines        3946     3773     -173     
==========================================
- Hits         3506     3208     -298     
- Misses        440      565     +125
Flag Coverage Δ
#tests 85.02% <ø> (-3.83%) ⬇️
Impacted Files Coverage Δ
src/virtualenv/seed/embed/wheels/__init__.py 100.00% <ø> (ø)
...nv/create/via_global_ref/builtin/cpython/mac_os.py 20.00% <0.00%> (-63.89%) ⬇️
...ualenv/create/via_global_ref/builtin/pypy/pypy3.py 75.00% <0.00%> (-25.00%) ⬇️
...irtualenv/seed/via_app_data/pip_install/symlink.py 86.36% <0.00%> (-6.82%) ⬇️
src/virtualenv/run/app_data.py 91.22% <0.00%> (-5.44%) ⬇️
.../create/via_global_ref/builtin/cpython/cpython3.py 95.12% <0.00%> (-2.71%) ⬇️
src/virtualenv/run/plugin/base.py 95.00% <0.00%> (-2.68%) ⬇️
src/virtualenv/info.py 97.50% <0.00%> (-2.50%) ⬇️
src/virtualenv/activation/via_template.py 97.50% <0.00%> (-2.50%) ⬇️
...rc/virtualenv/create/via_global_ref/builtin/ref.py 89.56% <0.00%> (-2.18%) ⬇️
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2bcb8d...2dbdfd2. Read the comment docs.

@gaborbernat gaborbernat force-pushed the upgrade branch 2 times, most recently from 43d74d7 to 2dbdfd2 Compare June 12, 2020 18:18
@gaborbernat gaborbernat merged commit b3d53fc into pypa:master Jun 12, 2020
@gaborbernat gaborbernat deleted the upgrade branch June 12, 2020 18:19
RowdyHowell
RowdyHowell reviewed Jun 12, 2020
View reviewed changes
setup.cfg
@@ -61,7 +61,7 @@ virtualenv.activate =
batch = virtualenv.activation.batch:BatchActivator
fish = virtualenv.activation.fish:FishActivator
powershell = virtualenv.activation.powershell:PowerShellActivator
python = virtualenv.activation.python:PythonActivator
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting an error that might be related to this merge. Is the change expected?

AttributeError: module 'virtualenv.activation.python' has no attribute 'PestythonActivator'

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just broke all of my production build pipelines as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to be honest, have no idea how this change made it in. Late Friday releases are always dangerous but wanted to get out a fix release to address peoples issues due to #1846 🤦 🤷‍♂️

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It happens. Thanks for the quick fix! @gaborbernat

@victor-torres
Copy link

victor-torres commented Jun 12, 2020 •
edited
Loading

Same issue here:

AttributeError: module 'virtualenv.activation.python' has no attribute 'PestythonActivator'

It's affecting my Bitbucket Pipelines :/

@GPHemsley GPHemsley mentioned this pull request Jun 12, 2020
Closed
@phrfpeixoto
Copy link

Haha. It seems we're missing tests here.

@pypa pypa locked as resolved and limited conversation to collaborators Jun 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@victor-torres victor-torres victor-torres left review comments

@sstoops sstoops sstoops left review comments

@RowdyHowell RowdyHowell RowdyHowell left review comments

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gaborbernat @victor-torres @phrfpeixoto @RowdyHowell @sstoops