-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix OpenSSL issue #447
Fix OpenSSL issue #447
Conversation
A [recent change](https://github.com/requests/toolbelt/compare/0.8.0..0.9.0) to requests-toolbelt results in twine attempting to reference the pyopenssl library when it is not a requirement. While this is addressed in requests-toolbelt, we should pin twine to the last working version.
Codecov Report
@@ Coverage Diff @@
## master #447 +/- ##
=======================================
Coverage 79.94% 79.94%
=======================================
Files 14 14
Lines 748 748
Branches 108 108
=======================================
Hits 598 598
Misses 113 113
Partials 37 37 Continue to review full report at Codecov.
|
After some discussion in requests/toolbelt#241 and requests/toolbelt#242 now attempting a fix in |
0.9.1 was released which should fix this. We'd need to cut a new release to fix the version constraints. If you accept the suggestion in-line then we can cut a release that just blacklists 0.9.0 and ensures no one accidentally gets that version |
Co-Authored-By: ryanwilsonperkin <[email protected]>
Thanks for the suggestion @sigmavirus24, applied your fix |
Due to a bad release of requests-toolbelt 0.9.0 discussed here pypa/twine#447 twine was attempting to refrence pyopenssl when it was not actually installed. These upgrades fix the issue.
Fixes #446
Using
twine
to push a package to a repository over HTTPS recently began resulting in the following stack trace:A recent change to
requests-toolbelt
results in twine attempting to reference thepyopenssl
library when it is not a requirement.While this is being addressed (requests/toolbelt#241) in
requests-toolbelt
, we should pin twine to the last working version.