add disable_progress_bar option to disable tqdm. #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add a disable_progress_bar option to settings. * Add a disable_progress_bar argument to init method of the repository. * Forward repository's disable_progress_bar property to tqdm ProgressBar as disable kwarg. * update README with help options for upload command.
Codecov Report
@@ Coverage Diff @@
## master #427 +/- ##
=========================================
+ Coverage 78.29% 80.1% +1.81%
=========================================
Files 14 14
Lines 751 754 +3
Branches 108 108
=========================================
+ Hits 588 604 +16
+ Misses 130 113 -17
- Partials 33 37 +4
Continue to review full report at Codecov.
|
* use mock instead of unittest.mock for python2.7 * Update tox.ini to depend on mock for py27 and pypy.
sigmavirus24
requested changes
Nov 25, 2018
tests/test_repository.py
Outdated
| @@ -16,7 +16,13 @@ | |||
| from twine import repository | |||
| from twine.utils import DEFAULT_REPOSITORY | |||
|
|
|||
| try: | |||
| from unittest import mock | |||
There was a problem hiding this comment.
This project doesn't use mock. Instead we use pretend which is already imported below and used throughout the test file. Please update your test to use that instead.
There was a problem hiding this comment.
Turns out I didn't need mock after all. Just replaced ProgressBar with a context manager and it did the trick. Thanks!
replace ProgressBar with a contextmanager and assert on the args. No need for a mock object.
sigmavirus24
approved these changes
Jan 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a disable_progress_bar option to settings.
Add a disable_progress_bar argument to init method of the repository.
Forward repository's disable_progress_bar property to
tqdm ProgressBar as disable kwarg.
update README with help options for upload command.
[x] ran tox -e lint
[x] ran tox against versions: 2.7, 3.6
[x] ran tox -e docs
[x] Added test to make sure tqdm is initialized with disable flag when repository is
initialized with disable_progress_bar parameter.
Closes #386