add support for uploading windows installers #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just a FYI that I'm planning on merging this. I just need to test it still. |
|
thanks for the feedback. one problem I noticed is that I couldn't upload greenlet's wininstaller for python 2.4. the zipfile contains just greenlet.pyd and greenlet.h. .msi files also cannot be uploaded. Do you have any plans to fix that? (something like a switch to "read metadata from another file but upload that .msi/.exe") |
|
I just rebased this and it seems to be working fine for |
|
This looks good to me. If you can give this a rebase @schmir I'll give it a test and merge it. |
|
I just noticed that this closes #64 as well |
|
Sorry, but I don't use python anymore and I'm not interested in doing that work. |
|
Superseded by #68 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
twine is currently not able to upload bdist_wininst generated windows installers. this pull requests adds support for it.