Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.7.2 breaks upload to internal pypi repo backed by artifactory #191

Closed
pbuckley opened this issue Jul 5, 2016 · 4 comments
Closed

1.7.2 breaks upload to internal pypi repo backed by artifactory #191

pbuckley opened this issue Jul 5, 2016 · 4 comments

Comments

@pbuckley
Copy link

pbuckley commented Jul 5, 2016

We used to be able to twine upload -r pypi-local dist/* (pypi-local is an internal artifactory server, configured according to the artifactory manaul https://www.jfrog.com/confluence/display/RTF/PyPI+Repositories). Starting July 5th (the 1.7.2 release) it began to fail with the below error. Can you confirm that 1.7.x introduced this new SSL requirement for twine, or is there a fix/workaround we could use? Currently dropped back to twine 1.6.5 and that fixed us.

    /home/user/python_env/lib/python2.7/site-packages/requests/packages/urllib3/util/ssl_.py:318:
    SNIMissingWarning: An HTTPS request has been made, but the SNI
    (Subject Name Indication) extension to TLS is not available on
    this platform. This may cause the server to present an incorrect
    TLS certificate, which can cause validation failures. You can
    upgrade to a newer version of Python to solve this. For more
    information, see
    https://urllib3.readthedocs.org/en/latest/security.html#snimissingwarning.

    SNIMissingWarning
    /home/user/python_env/lib/python2.7/site-packages/requests/packages/urllib3/util/ssl_.py:122:
    InsecurePlatformWarning: A true SSLContext object is not
    available. This prevents urllib3 from configuring SSL
    appropriately and may cause certain SSL connections to fail. You
    can upgrade to a newer version of Python to solve this. For more
    information, see
    https://urllib3.readthedocs.org/en/latest/security.html#insecureplatformwarning.

    InsecurePlatformWarning
    ValueError: No JSON object could be decoded
@sigmavirus24
Copy link
Member

  1. There is no 1.7.2 release.
  2. This is not a new SSL requirement. We updated to a newer minimum version of requests that warns you when you're making an HTTPS requests without good OpenSSL support in your version of Python.
  3. It looks like our pre-check to see if a package has already been uploaded (to support --skip-existing) is what's actually causing this to break.

@dstufft
Copy link
Member

dstufft commented Jul 5, 2016

#192 will probably fix this.

@pbuckley
Copy link
Author

pbuckley commented Jul 5, 2016

👍 thanks! (and sorry I typo'd 1.7.2, meant 1.7.1)

@dstufft
Copy link
Member

dstufft commented Jul 5, 2016

Fixed in afc9956.

@dstufft dstufft closed this as completed Jul 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants