-
-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v6 breaks on Centos7 due to older git #537
v6 breaks on Centos7 due to older git #537
Comments
Hi, we have the same issue here. Unfortunately, we cannot pin the version to 5.x because we use pre-commit which automatically creates a temporary virtualenv where it installs the current version of setuptools_scm. |
I confirm this issue and the proposed fix to pin to 5.x, I guess this is going to break quite a few builds 😄 |
Tracking this one too. It is awkward to pin because |
Yikes, will fix that when getting back to the computer |
I think I've got confused. I can't reproduce when installing from sdist, only from source (as one would hope). That dramatically reduces the issue's impact, and I'm happy to report my error. |
An sdist won't reach to git, stoneage git is a problem 👺 |
We are into this problem too, trying to pull in https://github.com/unioslo/pybofh/ as a dependency using pip building on RHEL 7 with git version 1.8.3.1-23. The output from "git log -n 1 HEAD --format=%cI" is simply "%cI", which break the build. |
bugfix is in test, release soon |
the release pipeline for 6.0.1 has startedand includes a fix |
I confirm 6.0.1 fixes the issue on CentOS 7. Thanks @RonnyPfannschmidt for the fast fix! |
Fix also works here. Thanks a lot for your superquick fix. |
Hi,
Changes between v5 and v6 results in downstream packages failing to build/install on Centos7, e.g. black
Centos7 seems to come with git 1.8.3.1 which doesn't support the
%cI
format as used byget_head_date()
resulting in the following error when using pre-commit+black:Installing either a newer git or
setuptools_scm~=5.0
works around the issue.The text was updated successfully, but these errors were encountered: