Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get branch If default 'git git_describe_command' failed #356

Merged
merged 1 commit into from
Dec 11, 2020

Conversation

hbasria
Copy link

@hbasria hbasria commented Sep 5, 2019

➜ mkdir demo
➜ cd demo
➜ git init
Initialized empty Git repository in demo/.git/
➜ git describe --dirty --tags --long --match . --first-parent
no matches found: .
➜ demo git symbolic-ref --short HEAD
master

Copy link
Contributor

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition, please extend the git tests to consider this case as well

@RonnyPfannschmidt
Copy link
Contributor

gentle ping, i'l aim for a release this weekend, unfortunately i cant pick up the test writing for this one until then, so if you manage to add the tests i can include it, else i will try to pick things up afterward

@RonnyPfannschmidt
Copy link
Contributor

turns out adding a test was trivial, thanks again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants