Fix mypy failure after multiple merges #4726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
force-pushed
the
fix-mypy-failure-after-multiple-merges
branch
3 times, most recently
from
25bd25a to
2419ec5
Compare
Avasam
force-pushed
the
fix-mypy-failure-after-multiple-merges
branch
from
2419ec5 to
e5ec6fd
Compare
Avasam
commented
Nov 1, 2024
Comment on lines
140
to
153
| easy_install = self.distribution.get_command_class('easy_install') | ||
|
|
||
| cmd = easy_install( | ||
| self.distribution, | ||
| args="x", | ||
| root=self.root, | ||
| record=self.record, | ||
| cmd = cast( | ||
| # We'd want to cast easy_install as type[easy_install_cls] but a bug in | ||
| # mypy makes it think easy_install() returns a Command on Python 3.12+ | ||
| # https://github.com/python/mypy/issues/18088 | ||
| easy_install_cls, | ||
| easy_install( # type: ignore[call-arg] | ||
| self.distribution, | ||
| args="x", | ||
| root=self.root, | ||
| record=self.record, | ||
| ), | ||
| ) |
There was a problem hiding this comment.
Ref.: python/mypy#18088
|
Uh, though one. Thank you very much @Avasam. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
@abravalheri for #4709 (comment)
As I thought, one PR made
Distribution.get_command_classno longer returnAnyfor mypy, the other madeinstall.do_egg_installtype-checked. Individually they both passed the CI.Pull Request Checklist
newsfragments/.(See documentation for details)