Adopt UTF-8 for .pth files on Python 3.13
#4306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The implementation in CPython was merged in 16 Apr and a new beta was released on 8 May (which I suppose includes the changes). Maybe we can start to consider merging now. There is a backport planned for 3.12, but I think if we try to consider it, it may make conditions more difficult: python/cpython#117917. |
Avasam
reviewed
Jul 31, 2024
|
I was waiting until we had a beta version of Python 3.13 on the CI, but with the change suggested in #4306 (comment), we might already be testing the change. Based on https://github.com/pypa/setuptools/actions/runs/10593714996/job/29355829351?pr=4306, it seems that CPython 3.12.5 is being installed by
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should wait until a compatible version of Python3.13 is released (probably a beta).
Summary of changes
.pthfiles on Python 3.13.pthon Python 3.13 tries first UTF-8 and then fallback to locale (this is done to avoid errors caused by mixing installations created by different versions ofsetuptoolsin the same environment)See reasoning in python/cpython#77102
Closes
Pull Request Checklist
newsfragments/.(See documentation for details)