Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge with pypa/distutils@22b9bcf #3553

Merged
merged 16 commits into from
Aug 21, 2022
Merged

Merge with pypa/distutils@22b9bcf #3553

merged 16 commits into from
Aug 21, 2022

Conversation

jaraco
Copy link
Member

@jaraco jaraco commented Aug 21, 2022

  • Suppress warnings in deprecated msvc compilers
  • Fix, again, finding headers during cross compiling
  • Rename _mangle_base to _make_relative and add documentation about its purpose. Ref New test_set_include_dirs leaves files in working directory distutils#169.
  • In _make_relative, remove deprecation warning. Ref New test_set_include_dirs leaves files in working directory distutils#169.
  • Extract method for _make_out_path.
  • In _msvccompiler, only override _make_out_path
  • In _msvccompiler, re-use _make_relative.
  • Extract property for mapping src extensions to out extensions.
  • Extract property for out_extensions in _msvccompiler
  • Deprecate bcppcompiler. Support for Borland C++ compiler was dropped for compiling Python in Drop support of Borland C compiler python/cpython#66782 (2014) and the borlandc.org web site no longer references a compiler. Best I can tell, this compiler hasn't been released for 22 years. Surely no one is using it.
  • Remove _msvccompiler._make_out_path.
  • In cygwincompiler, re-use object_filenames from ccompiler.
  • Add unit tests capturing the expectation

Summary of changes

Closes

Pull Request Checklist

jaraco and others added 16 commits August 16, 2022 18:48
Support for Borland C++ compiler was dropped for compiling Python in python/cpython#66782 (2014) and the borlandc.org web site no longer references a compiler. Best I can tell, this compiler hasn't been released for 22 years. Surely no one is using it.
The function is almost entirely redundant to the implementation in the parent class. The only difference is the order in which `strip_dir` is processed, but even there, it doesn't appear as if `strip_dir` is ever True, so take the risk and consolidate behavior.
Fix, again, finding headers during cross compiling
@kanavin
Copy link

kanavin commented Nov 3, 2022

Sadly, "Fix, again, finding headers during cross compiling" broke Yocto builds, which is a fairly important cross compile use case :-)

I'm investigating, may be 'our fault'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants