Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

easy_install: use --depth 1 with git clone when downloading requirements #1446

Closed
ubunatic opened this issue Jul 31, 2018 · 2 comments
Closed

Comments

@ubunatic
Copy link

Currently, when fetching requirements via git, easy_install fetches the complete git history. This can take very long for large repos.

To fix this, we can use --depth 1 when doing git clone and subsequently do a git fetch --depth 1 origin <rev> to download a specific revision.

I already prepared a branch to fix this, and I am preparing a PR just now (following the PR instructions).

I tested my branch already with a private repo using

to check the rev is None and rev is not None code-paths.

@benoit-pierre
Copy link
Member

easy_install is deprecated, use pip. Cloning with --depth 1 would break git describe, which could be problematic in some cases, see discussion on pip's tracker.

@ubunatic
Copy link
Author

OK. I thought we need to fix this in pip and here too. I will close the PR and read how this works in pip.

@jaraco jaraco closed this as completed Aug 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants