Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timezone error #1039

Merged
merged 3 commits into from
May 6, 2024
Merged

Fix timezone error #1039

merged 3 commits into from
May 6, 2024

Conversation

ap--
Copy link
Contributor

@ap-- ap-- commented May 2, 2024

Hello everyone,

this PR should close #1038

Let me know if I should test this differently or if another approach of handling the isoformat on py < 3.11 is preferred.

Have a great day!
Andreas 😃

Copy link
Contributor

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely quick fix

I'll see to getting it released this weekend as I'm a bit stretched atm

@RonnyPfannschmidt RonnyPfannschmidt merged commit 234b74f into pypa:main May 6, 2024
18 checks passed
@RonnyPfannschmidt
Copy link
Contributor

apologies for the delay, life had a curveball, release incoming

webknjaz added a commit to webknjaz/pylibssh that referenced this pull request Jun 4, 2024
This is necessary to let it deal with the datetime output format that
versions of Git 2.45.0 and above now produce.

Refs:
* pypa/setuptools-scm#1038
* pypa/setuptools-scm#1039
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

latest version of git breaks setuptools_scm with python3.9
2 participants