Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document the MANIFEST.in-replacing capabilities of setuptools_scm #199

Closed
ThomasWaldmann opened this issue Dec 19, 2017 · 6 comments
Closed

Comments

@ThomasWaldmann
Copy link

Dealing with MANIFEST.in and the package data include/exclude stuff in setup.py usually is a pain.
Either stuff is missing or you include crap accidentally.

setuptools_scm seems to handle this elegantly, but the README and docs focus on its version handling capabilities and don't tell much about the manifest/package-data related functionality.

After noticing that (more or less accidentally, iirc by some other docs mentioning that setuptools_scm can do that based on what's added to git) I did that PR: borgbackup/borg@feb428b

There was also a little discussion about it there: borgbackup/borg#3355

I didn't notice a problem with that yet.

The only thing to remember is to exclude unwanted files via MANIFEST.in.

@RonnyPfannschmidt
Copy link
Contributor

@ThomasWaldmann would you consider the current readme header sufficient or should there be a more complete example?

@ThomasWaldmann
Copy link
Author

Much better already!

Maybe it should mention both special cases that need attention:

  • SCM-managed but unwanted files must be excluded in MANIFEST.in
  • not-SCM-managed but wanted files must be included in MANIFEST.in

Guess the latter could be auto-generated stuff at / before sdist creation time.

@webknjaz
Copy link
Member

  • SCM-managed but unwanted files must be excluded in MANIFEST.in
  • not-SCM-managed but wanted files must be included in MANIFEST.in

@RonnyPfannschmidt I wonder if we should instead recommend customizing git_describe_command? Thoughts?

@RonnyPfannschmidt
Copy link
Contributor

@webknjaz i don't follow how the file finder is related to the describe command

@webknjaz
Copy link
Member

Oh, I must've confused its use seeing that it talks about the ability to have --exclude

@RonnyPfannschmidt
Copy link
Contributor

closing as solved, its mentioned in both the readme and the new mkdocs docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants