ci: restrict main branch for on push tests #1384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dukecat0
force-pushed
the
xuan.hu/only-tests-on-push-main
branch
from
3f96b95 to
fcb1cd1
Compare
dukecat0
approved these changes
Apr 30, 2024
huxuan
force-pushed
the
xuan.hu/only-tests-on-push-main
branch
from
fcb1cd1 to
925f824
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog.d/(if the patch affects the end users)Summary of changes
Currently, the workflow
testswill be triggerred when there is a new push on ALL branches, it will lead to redundant workflow runs when a pull request is created from the current repo rather than forked repo. For example, pre-commit update will lead to two tests workflow runs against same commit, one for push and the other for pull request:https://github.com/pypa/pipx/actions/runs/8884599944
https://github.com/pypa/pipx/actions/runs/8884599801
Test plan
Tested by running