Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uninstall does not uninstall injected apps binaries #221

Closed
itsayellow opened this issue Sep 21, 2019 · 2 comments
Closed

uninstall does not uninstall injected apps binaries #221

itsayellow opened this issue Sep 21, 2019 · 2 comments
Labels
bug Something isn't working windows

Comments

@itsayellow
Copy link
Contributor

Describe the bug
When injecting a package with the --include-apps flag, binaries are installed to the local_bin_dir. However, when uninstalling the parent package, these binaries are not removed, even though their symlinks are now broken (as the main venv package dir is removed.)

How to reproduce
pipx install ptpython
pipx inject --include-apps ptpython pylint
pipx uninstall ptpython

Expected behavior
The ptpython venv directory, ptpython binary symlinks, AND the pylint binary symlinks are all removed.

Actual behavior
The pylint binary symlinks remain in local_bin_dir, and are broken symlinks in the user's path.
@itsayellow itsayellow mentioned this issue Sep 21, 2019
Merged
@cs01 cs01 added the bug Something isn't working label Oct 3, 2019
@itsayellow
Copy link
Contributor Author

I think #246 fixes this except for Windows?

@itsayellow itsayellow mentioned this issue Dec 15, 2019
Closed
@cs01 cs01 added the windows label Dec 17, 2019
@itsayellow
Copy link
Contributor Author

Fixed also on Windows, possibly with #222 or #246.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cs01 @itsayellow