You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
Today I reinstall pipx and noticed that when I was installing a local package I was constantly getting ⚠️ Ignoring --editable install option. pipx disallows it for anything but a local path, to avoid having to create a new src/ directory.
How to reproduce
# Install latest pipxcd~/dev/my-python-project
pipx install --editable --force .# Gets message about --editable being ignore
Expected behavior --editable should not be ignore.
Investigation
After some debugging the issue seems to be coming from this commit from packaging pypa/packaging#684 where they removed URL validation. Because there is no longer an InvalidRequirement being thrown, in the following block the else branch gets executed which erroneously sets valid_url as '.'
I’ve merged a change into main that should fix the issue. Anyone landing here with the same issue please feel free to download and test code in main and give feedback so we know if the fix works!
Describe the bug
Today I reinstall pipx and noticed that when I was installing a local package I was constantly getting
⚠️ Ignoring --editable install option. pipx disallows it for anything but a local path, to avoid having to create a new src/ directory.
How to reproduce
Expected behavior
--editable
should not be ignore.Investigation
After some debugging the issue seems to be coming from this commit from packaging pypa/packaging#684 where they removed URL validation. Because there is no longer an
InvalidRequirement
being thrown, in the following block the else branch gets executed which erroneously setsvalid_url
as '.'https://github.com/pypa/pipx/blob/main/src/pipx/package_specifier.py#L80-L87
Because valid_url is set to something, valid_local_path is no longer being set and therefore pipx thinks
.
is not a local package and therefore ignores the --editable flag.https://github.com/pypa/pipx/blob/main/src/pipx/package_specifier.py#L89-L95
packaging
released this change on 23.2 which was releases Oct1. Reverting packaging to 23.1 fixes the issue.The text was updated successfully, but these errors were encountered: