pipenv check can't ignore multiple vulnerabilities #2679
Labels
good first issue
Issues suitable as a newcomer to get familiar with Pipenv!
Type: Bug 🐛
This issue is a bug.
Issue description
When you run
pipenv check
with multiple--ignore
flags, it fails to pass them tosafety
tool correctly.Expected result
I'd expect both vulnerabilities to be passed to
safety
correctly and thus be ignored bysafety
tool.Actual result
Fix
This seems to be caused by the way vulnerability numbers are being passed to
safety
here:https://github.com/pypa/pipenv/blob/master/pipenv/core.py#L2237
This code produces
--ignore 36333--ignore 36351
- notice lack of space after 36333!This can be fixed by adding a space in front of join string:
Steps to replicate
Please run
$ pipenv --support
, and paste the results here.$ pipenv --support
Pipenv version:
'2018.7.1'
Pipenv location:
'/usr/local/Cellar/pipenv/2018.7.1/libexec/lib/python3.7/site-packages/pipenv'
Python location:
'/usr/local/Cellar/pipenv/2018.7.1/libexec/bin/python3.7'
Other Python installations in
PATH
:2.7
:/usr/local/bin/python2.7
2.7
:/usr/local/bin/python2.7
2.7
:/usr/local/bin/python2.7
2.7
:/usr/local/bin/python2.7
2.7
:/usr/local/bin/python2.7
2.7
:/usr/local/bin/python2.7
2.7
:/usr/local/bin/python2.7
2.7
:/usr/local/bin/python2.7
2.7
:/usr/local/bin/python2.7
2.7
:/usr/bin/python2.7
3.7
:/usr/local/bin/python3.7m
3.7
:/usr/local/bin/python3.7
3.7
:/usr/local/bin/python3.7
3.7
:/usr/local/bin/python3.7
3.7
:/usr/local/bin/python3.7
3.7
:/usr/local/bin/python3.7
3.7
:/usr/local/bin/python3.7
3.7
:/usr/local/bin/python3.7
3.7
:/usr/local/bin/python3.7
2.7.15
:/usr/local/bin/python
2.7.15
:/usr/local/bin/python
2.7.15
:/usr/local/bin/python
2.7.15
:/usr/local/bin/python
2.7.15
:/usr/local/bin/python
2.7.15
:/usr/local/bin/python
2.7.15
:/usr/local/bin/python
2.7.15
:/usr/local/bin/python
2.7.10
:/usr/bin/python
2.7.15
:/usr/local/bin/python2
2.7.15
:/usr/local/bin/python2
2.7.15
:/usr/local/bin/python2
2.7.15
:/usr/local/bin/python2
2.7.15
:/usr/local/bin/python2
2.7.15
:/usr/local/bin/python2
2.7.15
:/usr/local/bin/python2
2.7.15
:/usr/local/bin/python2
3.7.0
:/usr/local/bin/python3
3.7.0
:/usr/local/bin/python3
3.7.0
:/usr/local/bin/python3
3.7.0
:/usr/local/bin/python3
3.7.0
:/usr/local/bin/python3
3.7.0
:/usr/local/bin/python3
3.7.0
:/usr/local/bin/python3
3.7.0
:/usr/local/bin/python3
PEP 508 Information:
System environment variables:
PATH
TERM_PROGRAM
VIRTUALENVWRAPPER_PROJECT_FILENAME
VIRTUALENVWRAPPER_SCRIPT
ANDROID_HOME
SHELL
TERM
HISTSIZE
CLICOLOR
TMPDIR
Apple_PubSub_Socket_Render
TERM_PROGRAM_VERSION
TERM_SESSION_ID
USER
HISTFILESIZE
SSH_AUTH_SOCK
__CF_USER_TEXT_ENCODING
WORKON_HOME
LSCOLORS
VIRTUALENVWRAPPER_PYTHON
_
VIRTUALENVWRAPPER_HOOK_DIR
PWD
JAVA_HOME
LANG
ITERM_PROFILE
XPC_FLAGS
ITERM_ORIG_PS1
XPC_SERVICE_NAME
COLORFGBG
HOME
SHLVL
ITERM_PREV_PS1
ITERM_SESSION_ID
LOGNAME
LESS
GOPATH
VIRTUALENVWRAPPER_WORKON_CD
DISPLAY
COLORTERM
PYTHONDONTWRITEBYTECODE
PIP_PYTHON_PATH
Pipenv–specific environment variables:
Debug–specific environment variables:
SHELL
:/bin/bash
LANG
:en_GB.UTF-8
Contents of
Pipfile
('/Users/.../.../.../Pipfile'):Contents of
Pipfile.lock
('/Users/.../.../.../Pipfile.lock'):The text was updated successfully, but these errors were encountered: