Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easier way to keep pip up to date #1884

Closed
uranusjr opened this issue Mar 30, 2018 · 3 comments
Closed

Easier way to keep pip up to date #1884

uranusjr opened this issue Mar 30, 2018 · 3 comments
Labels
Type: Discussion This issue is open for discussion.

Comments

@uranusjr
Copy link
Member

Not sure if this is a good idea, but throwing it out here first.

pip 9.0.3 recently came out and I started to get the upgrade message everywhere, but the message can be a little misleading for PIpenv users

You are using pip version 9.0.2, however version 9.0.3 is available.
You should consider upgrading via the 'python -m pip install --upgrade pip' command.

This is not the command to run unless you’re in the subshell (you need the pipenv run prefix), and may cause confusion. Neither pip nor PIpenv is doing things wrong here, but I feel the UX can be improved.

Some wild thoughts—

  • Use --disable-pip-version-check when invoking pip as a subprocess to avoid the message from appearing, and/or hijack it to display our own version.
  • Make pipenv sync or pipenv install take care of upgrading pip in the virtualenv.
@techalchemy
Copy link
Member

We can just use the temp_environ() context manager when we run pip and set PIP_DISABLE_PIP_VERSION_CHECK which I assume works like any other pip environment variable?

@uranusjr
Copy link
Member Author

Yes, probably. The thing is if we turn off the pip upgrade notice, Pipenv will need to offer its own way to keep pip up-to-date.

@uranusjr uranusjr added the Type: Discussion This issue is open for discussion. label Jun 6, 2018
@matteius
Copy link
Member

pipenv relies on its vendor'd pip now - it no longer calls it out as an install time requirement, though virtualenv installs pip anyway into the virtualenv which seems fine as users can invoke pip to install/remove a package with intend to bypass Pipfile/Pipfile.lock. I am not sure that there is a TODO here anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Discussion This issue is open for discussion.
Projects
None yet
Development

No branches or pull requests

3 participants