Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipenv fails to install from github by ref and tag #1126

Closed
BeyondEvil opened this issue Nov 27, 2017 · 2 comments · Fixed by #1128
Closed

Pipenv fails to install from github by ref and tag #1126

BeyondEvil opened this issue Nov 27, 2017 · 2 comments · Fixed by #1128

Comments

@BeyondEvil
Copy link

Trying to install from github using ref and tag fails, because pipenv "destroys" the format of the url removing git: from the reference.

Describe your environment
  1. OS Type OSX 10.12.6
  2. Python version: $ python -V 3.6.3
  3. Pipenv version: $ pipenv --version 8.3.2
Expected result

The reference in Pipfile looks like this (which is correct)
pytest-tags = {git = "git://github.com/Projectplace/pytest-tags.git", editable = true, ref = "1.5"}

But in the Pipfile.lock file, it's
"git": "//github.com/Projectplace/pytest-tags.git"

Workaround is to re-add git: to the pipfile.lock manually.

Actual result
Locking [dev-packages] dependencies…
Locking [packages] dependencies…
Updated Pipfile.lock (24ab2e)!
Installing dependencies from Pipfile.lock (24ab2e)…
  🐍   ▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉ 19/19 — 00:00:05
An error occurred while installing -e git+//github.com/Projectplace/pytest-tags.git@c8cf057c03a1fa30769c0328efa41d4826e03bcf#egg=pytest-tags! Will try again.
Installing initially–failed dependencies…
Obtaining pytest-tags from git+//github.com/Projectplace/pytest-tags.git@c8cf057c03a1fa30769c0328efa41d4826e03bcf#egg=pytest-tags
  Cloning github.com/Projectplace/pytest-tags.git (to c8cf057c03a1fa30769c0328efa41d4826e03bcf) to /Users/jimbrannlund/.local/share/virtualenvs/dpo-automation-NuB7OARD/src/pytest-tags
fatal: repository 'github.com/Projectplace/pytest-tags.git' does not exist

Command "git clone -q github.com/Projectplace/pytest-tags.git /Users/jimbrannlund/.local/share/virtualenvs/dpo-automation-NuB7OARD/src/pytest-tags" failed with error code 128 in None```

@techalchemy
Copy link
Member

@BeyondEvil I can reproduce this for editable installs, will look into it

techalchemy added a commit to techalchemy/pipenv that referenced this issue Nov 27, 2017
- Fixes pypa#1126
- Does a simple check before stripping the VCS prefix on
a requirement.uri in pipenv.utils.convert_deps_from_pip
@BeyondEvil
Copy link
Author

I have to say, I'm really impressed by the short turnaround (4 hours) from reported issue to merged fix! @techalchemy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants