From ec57146f42240677652e304e5460b8676f63596a Mon Sep 17 00:00:00 2001 From: Dan Ryan Date: Sun, 1 Oct 2017 23:07:58 -0400 Subject: [PATCH] Add more VCS checks, fixes #806 --- pipenv/cli.py | 2 +- pipenv/utils.py | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/pipenv/cli.py b/pipenv/cli.py index ef7527d372..d0606c6e5d 100644 --- a/pipenv/cli.py +++ b/pipenv/cli.py @@ -1800,7 +1800,7 @@ def install( # Warn if --editable wasn't passed. converted = convert_deps_from_pip(package_name) key = [k for k in converted.keys()][0] - if is_vcs(converted[key]) and not converted[key].get('editable'): + if is_vcs(key) or is_vcs(converted[key]) and not converted[key].get('editable'): click.echo( '{0}: You installed a VCS dependency in non–editable mode. ' 'This will work fine, but sub-depdendencies will not be resolved by {1}.' diff --git a/pipenv/utils.py b/pipenv/utils.py index e7339c1485..8d48ff029c 100644 --- a/pipenv/utils.py +++ b/pipenv/utils.py @@ -714,6 +714,8 @@ def is_vcs(pipfile_entry): if hasattr(pipfile_entry, 'keys'): return any(key for key in pipfile_entry.keys() if key in VCS_LIST) + elif isinstance(pipfile_entry, six.string_types): + return pipfile_entry.startswith(VCS_LIST) return False