Add more VCS checks, fixes #806

pypa · Oct 2, 2017 · ec57146 · ec57146
1 parent 6e32b6f
commit ec57146
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/pipenv/cli.py b/pipenv/cli.py
@@ -1800,7 +1800,7 @@ def install(
             # Warn if --editable wasn't passed.
             converted = convert_deps_from_pip(package_name)
             key = [k for k in converted.keys()][0]
-            if is_vcs(converted[key]) and not converted[key].get('editable'):
+            if is_vcs(key) or is_vcs(converted[key]) and not converted[key].get('editable'):
                 click.echo(
                     '{0}: You installed a VCS dependency in non–editable mode. '
                     'This will work fine, but sub-depdendencies will not be resolved by {1}.'

diff --git a/pipenv/utils.py b/pipenv/utils.py
@@ -714,6 +714,8 @@ def is_vcs(pipfile_entry):
 
     if hasattr(pipfile_entry, 'keys'):
         return any(key for key in pipfile_entry.keys() if key in VCS_LIST)
+    elif isinstance(pipfile_entry, six.string_types):
+        return pipfile_entry.startswith(VCS_LIST)
     return False