Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert addition of un-suffixed pip CLI entry points for invocation check on Windows #7557

Merged
merged 2 commits into from
Jan 7, 2020

Conversation

pradyunsg
Copy link
Member

Closes #7358
Reopens #6841
Partially reverts #6864

@pradyunsg pradyunsg added skip news Does not need a NEWS file entry (eg: trivial changes) type: bugfix labels Jan 6, 2020
@pradyunsg pradyunsg added this to the 20.0 milestone Jan 6, 2020
@pradyunsg
Copy link
Member Author

pradyunsg commented Jan 7, 2020

Note: @uranusjr and I investigated why the tests failed and it seems like calls made from script.run are resulting in sys.argv[0] to not include .exe suffix. The tests were working earlier, since the .exe suffix wasn't required to pass; i.e. it used the non-suffixed name to pass even when checking a different suffix. :)

I've dropped all the tests since they're not valid tests that are not useful as-is without significant investigation / reworking or are tests for functionality that doesn't exist.

@pradyunsg pradyunsg merged commit 6c51512 into pypa:master Jan 7, 2020
@pradyunsg pradyunsg deleted the revert/6864 branch January 7, 2020 08:16
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Feb 6, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

protect_pip_from_modification_on_windows check breaks some valid use cases
2 participants