Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add debug logging to filter_unallowed_hashes() #6714

Merged
merged 2 commits into from
Jul 15, 2019
Merged

Add debug logging to filter_unallowed_hashes() #6714

merged 2 commits into from
Jul 15, 2019

Conversation

cjerdonek
Copy link
Member

This is a follow-up to PR #6699 that adds debug logging to filter_unallowed_hashes() (a bit like the "skipped link" debug logging after each call to LinkEvaluator.evaluate_link()).

@cjerdonek cjerdonek added C: finder PackageFinder and index related code skip news Does not need a NEWS file entry (eg: trivial changes) labels Jul 14, 2019
@cjerdonek cjerdonek mentioned this pull request Jul 14, 2019
Closed
xavfernandez
xavfernandez approved these changes Jul 15, 2019
View reviewed changes
Copy link
Member

@xavfernandez xavfernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not completely convinced by the need for the project name in the log but 🤷‍♂️

@cjerdonek
Copy link
Member Author

Thanks!

@cjerdonek cjerdonek merged commit 90fa087 into pypa:master Jul 15, 2019
@cjerdonek cjerdonek deleted the filter-unallowed-hashes-logging branch July 15, 2019 23:30
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Aug 14, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@xavfernandez xavfernandez xavfernandez approved these changes

Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation C: finder PackageFinder and index related code skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cjerdonek @xavfernandez