-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move towards declarative setup.cfg #6502
Conversation
I’d expect |
But which version will it take then? The one from the package-to-be-installed or the one from the package-already-installed? |
removed all logic from setup.py that figured out the version
The to-be-installed one, of course! 😄 This is not specific to pip either—the same happens when you upgrade a package (i.e. install a module into an environment that already has a module of the same name). |
Already fixed -- this also removed a lot of now-unused code from |
What version of setuptools added support for setup.cfg? pip should be on the tail end of adopters for functionality since anyone with an existing install too old won't be able to upgrade seamlessly. |
Good morning me, don't close PRs when you want to comment on them. |
Can we restart the AppVeyour test? |
does setuptools support receiving its setup() parameters from pyproject.toml yet? |
no |
It looks like this is the issue for that: pypa/setuptools#1688 (and also pypa/setuptools#1160) |
I'm gonna take the liberty of closing this on the basis of rationale provided in #6501 just now. To be clear, I am not forcing my stated position there and will be more than happy to reopen this PR, if we're going to do this. I do think folks will agree though so I'm potentially reducing future work for maintainers by doing this eagerly. |
This fix moves most of the stuff from setup.py to setup.cfg. (Closes: #6501)
I accidentally referenced the wrong bug in one commit, as I thought was fixing this issue for setuptools. Anyways, the fix also applies to PIP. I couldn't migrate the version to setup.cfg, as we can't just use
attr: src.pip.__version__
here.