Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move towards declarative setup.cfg #6502

Closed
wants to merge 9 commits into from
Closed

Conversation

venthur
Copy link
Contributor

@venthur venthur commented May 14, 2019

This fix moves most of the stuff from setup.py to setup.cfg. (Closes: #6501)

I accidentally referenced the wrong bug in one commit, as I thought was fixing this issue for setuptools. Anyways, the fix also applies to PIP. I couldn't migrate the version to setup.cfg, as we can't just use attr: src.pip.__version__ here.

setup.cfg Outdated Show resolved Hide resolved
@uranusjr
Copy link
Member

I’d expect attr: pip.__version__ to work; otherwise it seems like an oversight that setuptools should fix.

@venthur
Copy link
Contributor Author

venthur commented May 15, 2019

But which version will it take then? The one from the package-to-be-installed or the one from the package-already-installed?

removed all logic from setup.py that figured out the version
@uranusjr
Copy link
Member

uranusjr commented May 15, 2019

The to-be-installed one, of course! 😄 This is not specific to pip either—the same happens when you upgrade a package (i.e. install a module into an environment that already has a module of the same name).

@venthur
Copy link
Contributor Author

venthur commented May 15, 2019

Already fixed -- this also removed a lot of now-unused code from setup.py.

@pradyunsg
Copy link
Member

What version of setuptools added support for setup.cfg?

pip should be on the tail end of adopters for functionality since anyone with an existing install too old won't be able to upgrade seamlessly.

@pradyunsg pradyunsg closed this May 15, 2019
@pradyunsg pradyunsg reopened this May 15, 2019
@pradyunsg
Copy link
Member

Good morning me, don't close PRs when you want to comment on them.

@venthur
Copy link
Contributor Author

venthur commented May 15, 2019

Can we restart the AppVeyour test?

@dholth
Copy link
Member

dholth commented May 16, 2019

does setuptools support receiving its setup() parameters from pyproject.toml yet?

@RonnyPfannschmidt
Copy link
Contributor

no

@cjerdonek
Copy link
Member

does setuptools support receiving its setup() parameters from pyproject.toml yet?

It looks like this is the issue for that: pypa/setuptools#1688 (and also pypa/setuptools#1160)

@pradyunsg
Copy link
Member

I'm gonna take the liberty of closing this on the basis of rationale provided in #6501 just now.

To be clear, I am not forcing my stated position there and will be more than happy to reopen this PR, if we're going to do this. I do think folks will agree though so I'm potentially reducing future work for maintainers by doing this eagerly.

@pradyunsg pradyunsg closed this May 23, 2019
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 22, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use declarative setup.cfg
7 participants