Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regression test for check_requires_python with no package metadata #6003

Closed
wants to merge 1 commit into from

Conversation

cytolentino
Copy link
Contributor

Add a regression test for check_requires_python for the case where a package has no metadata (see issue #5082).

@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will be eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label May 26, 2019
@pradyunsg
Copy link
Member

@cjerdonek We should add an equivalent regression test for the refactored version if this code.

@cjerdonek
Copy link
Member

cjerdonek commented May 26, 2019

@cjerdonek We should add an equivalent regression test for the refactored version if this code.

Good find. Will do. Also, I checked the code causing #5082, and the code with the bug is happening higher up the stack inside utils.packaging.get_metadata(), so that still needs to get fixed.

@cjerdonek
Copy link
Member

We should add an equivalent regression test for the refactored version if this code.

@pradyunsg I did this here: #6542

@cjerdonek
Copy link
Member

This was superseded by PR #6542 linked above, so closing.

Thanks for your work on this @cytolentino, even though this wound up getting fixed a different way.

@cjerdonek cjerdonek closed this May 26, 2019
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 26, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation needs rebase or merge PR has conflicts with current master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants