Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolate, reuse PackageFinder best candidate logic #5971

Merged
merged 5 commits into from
Apr 16, 2019
Merged

Isolate, reuse PackageFinder best candidate logic #5971

merged 5 commits into from
Apr 16, 2019

Commits on Apr 2, 2019

  1. Isolate, reuse PackageFinder best candidate logic 

    Split out how PackageFinder finds the best candidate, and reuse it in the
self version check, to avoid the latter duplicating (and incorrectly
implementing) the same logic.
    @uranusjr
    uranusjr committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    ea1d5ac View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2019

  1. Turn FoundCandidates properties into functions 

    Also fix the missing parse_version call, and add comment for it.
    @uranusjr
    uranusjr committed Apr 8, 2019
    Configuration menu
    Copy the full SHA
    1e3b4db View commit details
    Browse the repository at this point in the history

  2. Make specifier argument optional

    @uranusjr
    uranusjr committed Apr 8, 2019
    Configuration menu
    Copy the full SHA
    adc498a View commit details
    Browse the repository at this point in the history

  3. Keep linters happy

    @uranusjr
    uranusjr committed Apr 8, 2019
    Configuration menu
    Copy the full SHA
    4dfda6b View commit details
    Browse the repository at this point in the history

  4. Fix mock

    @uranusjr
    uranusjr committed Apr 8, 2019
    Configuration menu
    Copy the full SHA
    2882042 View commit details
    Browse the repository at this point in the history