[WIP] Try to use user site-packages more often #4868
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It makes it install in global site-packages.
We want use user site-packages whenever possible.
pradyunsg
added
state: needs discussion
|
Uhm. The configuration related stuff gets messy if we do it this way. :'( I'll go ahead with trying to implement #4575 directly instead. |
pradyunsg
changed the title
| @@ -206,6 +216,11 @@ def run(self, options, args): | |||
| install_options.append('--user') | |||
| install_options.append('--prefix=') | |||
|
|
|||
| # If --user or --global is not passed, use some heuristic to determine | |||
There was a problem hiding this comment.
doesnt this have to go above to ensure the sanity check and the install option fixup?
There was a problem hiding this comment.
Yep.
Note to self: Be more careful with your merges.
Closing this PR. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1668
Closes #2418 (this is that carried forward)
Closes #4865
This is another attempt at closing #1668.
State: