Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new 'wheel' dependencies impact on pip freeze #8763

Closed
sbidoul opened this issue Aug 14, 2020 · 5 comments
Closed

new 'wheel' dependencies impact on pip freeze #8763

sbidoul opened this issue Aug 14, 2020 · 5 comments
Labels
C: freeze 'pip freeze' related

Comments

@sbidoul
Copy link
Member

sbidoul commented Aug 14, 2020

pip freeze excludes pip, setuptools, and wheel by default, unless the --all option is passed.

Now that wheel depends on packaging which in turn depends on pyparsing and six, new, possibly unexpected lines are emitted by pip freeze.

I'm not sure yet if it is a problem in practice.

@sbidoul sbidoul added C: freeze 'pip freeze' related state: needs discussion This needs some more discussion labels Aug 14, 2020
@sbidoul
Copy link
Member Author

sbidoul commented Aug 15, 2020

This issue went away with wheel 0.35.1 which now vendors packaging.tags. Thanks @agronholm !

@sbidoul sbidoul closed this as completed Aug 15, 2020
@agronholm
Copy link
Contributor

Note that vendoring is only an interim solution until we can get rid of the unnecessary dependencies. One plan is to separate the "tags" part of packaging into its own library. If this happens, wheel will add an install dependency on that.

@sbidoul sbidoul reopened this Aug 15, 2020
@xavfernandez
Copy link
Member

Related to #4256

@ichard26
Copy link
Member

This issue is probably not worth keeping around anymore as pip freeze will show setuptools and wheel starting on Python 3.12 and higher.

def _should_suppress_build_backends() -> bool:
return sys.version_info < (3, 12)
def _dev_pkgs() -> AbstractSet[str]:
pkgs = {"pip"}
if _should_suppress_build_backends():
pkgs |= {"setuptools", "distribute", "wheel"}
return pkgs

@uranusjr
Copy link
Member

Yes; I don’t think this is relevant anymore since setuptools and wheel are no longer “built-in” (in quotes).

@pradyunsg pradyunsg removed the state: needs discussion This needs some more discussion label Apr 19, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C: freeze 'pip freeze' related
Projects
None yet
Development

No branches or pull requests

6 participants