Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constraints override pinned requifrements #6495

Closed
jazzblue opened this issue May 10, 2019 · 2 comments
Closed

Constraints override pinned requifrements #6495

jazzblue opened this issue May 10, 2019 · 2 comments
Labels
auto-locked Outdated issues that have been locked by automation C: dependency resolution About choosing which dependencies to install resolution: duplicate Duplicate of an existing issue/PR type: support User Support

Comments

@jazzblue
Copy link

jazzblue commented May 10, 2019 •
edited
Loading

Environment

  • pip version: 19.1.1
  • Python version: PyPy 7.0.0
  • OS: OS X

Description and How to Reproduce
constraints. txt:
urllib3>1.23

requirements.txt:
urllib3==1.24.3

When I run:
pip install -c constraints.txt -r requirements.txt

It installs:
Successfully installed urllib3-1.25.2

This means that the pinned requirement urllib3==1.24.3 is ignored and is not what is expected.

Expected behavior
Should install urllib3==1.24.3 not 1.25.2.
@xavfernandez
Copy link
Member

I'd say this is an other duplicate of #988.

@pradyunsg pradyunsg added the S: needs triage Issues/PRs that need to be triaged label Jun 22, 2019
@chrahunt chrahunt added C: dependency resolution About choosing which dependencies to install resolution: duplicate Duplicate of an existing issue/PR type: support User Support labels Sep 14, 2019
@triage-new-issues triage-new-issues bot removed S: needs triage Issues/PRs that need to be triaged labels Sep 14, 2019
@chrahunt
Copy link
Member

Agreed. The current behavior is indicated in the docs, that is, pip will use the first requirement (or constraint) found of those provided. Once #988 is fixed then this will not be an issue since we would choose the narrower version constraint (urllib3==1.24.3).

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Oct 14, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation C: dependency resolution About choosing which dependencies to install resolution: duplicate Duplicate of an existing issue/PR type: support User Support
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@xavfernandez @chrahunt @pradyunsg @jazzblue