-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNIMissingWarning / InsecurePlatformWarning not fixable with pip 9.0 / 9.0.1 #4098
Comments
For comparison, here's a log on another fresh Ubuntu install showing that the errors go away when I install the various security packages if I'm using pip 8.1.2:
[snip]
|
So this is a bit of a sticky issue. We've modified our bundled copies of the libraries so that they will not load any of the C libraries because on some OSs (particularly Windows) if pip imports the C library then it becomes impossible for pip to actually upgrade or uninstall that library (because importing locks the .dll from deletion). The downside of this is that it means you're stuck with what your Python is able to provide. I see a few ways around this:
If we pick (3) we'd still need to pick which of (1) or (2) we want to happen on platforms where our C libraries support is disabled. |
Heh, I was just poking around in the codebase and was about to point to your commit at cab0177, which I assume is the change that you're referring to. From our perspective (PythonAnywhere PaaS), while we really do want to upgrade our default system Python 2.7 to something more recent, it's really hard in the short term because people have (eg.) |
One thing I would definitely suggest, though, if you don't disable the warnings completely, is that you change them. Right now pip is printing out (thanks to urllib3) messages like
...which is telling people to go to a page that tells them to install something, and installing that thing doesn't fix the problem. That's bound to lead to confusion. |
I am in a very similar situation to @gpjt where it is not all that easy to coordinate an update to a newer version of Python for all of our users. I agree that solutions (3) and (1) seem like the way to go along with a change in the warning message shown to more accurately reflect the situation. In my opinion, reducing the security across all platforms for the sake of the lowest common denominator seems like the wrong way to go. |
To help other folks hitting this same issue, I thought I was going crazy since we are indeed pinning |
If someone makes a PR for (1) and (3) I would be happy to accept it, otherwise I'll try to get to it myself. |
any updates? |
How do we progress this issue? If we're going to hold the release of pip 10 till this is resolved, who is in a position to move it forward? |
There's 2 existing PRs for it. Both have merge conflicts. Someone would have to resolve the conflicts for one of them and then it shouldn't take long to merge since I think there seems to be a general preference to taking the same approach as those PRs. |
So - while I see the need for this, AIUI this is an existing behaviour in pip 9. If we don't fix it in 10, we're not making any behaviour worse for the user, simply not fixing an issue. And if people fix the security warnings this is telling them about, that resolves the issue for them. So what I'm saying is that I'm fine with pushing to get this ready for pip 10, but if no-one has time to work on it, I think it's fine to remove the blocker tag. What I don't want is to have pip 10 blocked indefinitely because we don't have anyone working on this. Does that seem reasonable? |
Yep! |
btw -- they can't. That's the issue. |
Ah. OK. I was going off the original comment "For various reasons we can't upgrade to Python 2.7.9 or higher" which I took to mean that if they did upgrade their Python, they'd be OK. (I don't think "issues on outdated versions of Python 2.7" qualifies as a release blocker, is all I'm saying). |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description:
For various reasons we can't upgrade to Python 2.7.9 or higher. With pip 8.1.2, we (quite understandably) got the SNIMissingWarning / InsecurePlatformWarning errors when trying to install something. These were fixable by installing various security packages.
However, pip 9.0 and 9.0.1 are not fixed by running the same command.
What I've run:
The following log is from a fresh Ubuntu install, after a
sudo apt-get update
, asudo apt-get upgrade
, and a reboot.[snip]
The text was updated successfully, but these errors were encountered: