Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pip Fails to install packages which has git+ links (seems to also be a setup.py issue sadly when it loads up and lists a git+ link as well. #3609

Closed
AraHaan opened this issue Apr 9, 2016 · 3 comments
Labels
auto-locked Outdated issues that have been locked by automation

Comments

@AraHaan
Copy link
Contributor

AraHaan commented Apr 9, 2016

  • Pip version: latest
  • Python version: 3.5.1
  • Operating System: Windows 7 Ultimate x64 (AMD64 to be exact)

Description:

When I try running a package from my github repo that has setup.py it fails to work when the requirements in the list that it loads the requirements.txt file on that package has a git+ link it fails to install anything from the requirements that requires that package that requires other things which has a git+ link.

basically if I do

pip install --upgrade git+https://github.com/AraHaan/DecoraterBotCore

and if inside the requirements.txt file on that lib that my discord bot uses has this

git+https://github.com/AraHaan/discord.py

it fails to recognize that it is a git+ it works fine when ran locally but not when you try to pip install the Discord Bot core which contains 99.9% of the code to it. (rest is just a script to call it all and json configs of many things.

@AraHaan AraHaan changed the title Pip Fails to install packages which has git+ links (seems to also be a setup.py issue sadly when it loads up by lists a git+ link as well. Pip Fails to install packages which has git+ links (seems to also be a setup.py issue sadly when it loads up and lists a git+ link as well. Apr 9, 2016
@Ivoz
Copy link
Contributor

Ivoz commented Apr 9, 2016

To start off, it would likely be helpful to you to read dstuff's setup.py vs requirements.txt. Following this advice, I would advise you not to use requirements.txt within setup.py install_requires.

Here are some advice:

running pip install -e . inside a project directory will install that project in 'editable' (development) fashion. However -e . can also be put in, say, the last line of a requirements.txt that's in a project directory to have the same effect, when running pip install -r requirements.txt.

So, e.g, for both your projects, I would recommend moving your stable packaging requirements to their setup.py's install_requires field.

In DecoratorBotCore, I would recommend having

-e git+https://github.com/AraHaan/discord.py
-e .

For example.

@AraHaan
Copy link
Contributor Author

AraHaan commented Apr 9, 2016

oh I see I could do dependency_links I did not see this before maybe it will support github itself.
And maybe since they have git+ I could prob store them and load only the links from json separate from the requirements.txt

@dstufft
Copy link
Member

dstufft commented Mar 24, 2017

Closing this, it appears to have been a case of expected behavior.

@dstufft dstufft closed this as completed Mar 24, 2017
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 3, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation
Projects
None yet
Development

No branches or pull requests

3 participants