Drop support for soon-EOL Python 3.6 #10641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wheeeee! Thanks for picking this up @hugovk! ^.^ Could you also clear out the usage of utils.parallel and drop the module too? Those utilities are somewhat redundant/useless now that it's not possible/permitted to have a non-threading / non-multiprocessing platform. |
|
How's this? |
DiddiLeija
approved these changes
Nov 8, 2021
pradyunsg
approved these changes
Nov 12, 2021
| @@ -254,7 +253,7 @@ def latest_info( | |||
| dist.latest_filetype = typ | |||
| return dist | |||
|
|
|||
| for dist in map_multithread(latest_info, packages): | |||
| for dist in map(latest_info, packages): | |||
There was a problem hiding this comment.
Hmm... We should bring this into a multi-threaded regime in a follow up!
|
OMIGOD. I JUST REALISED THAT WE CAN USE DATACLASSES NOW! |
|
All the new* things! https://docs.python.org/3/whatsnew/3.7.html * 2018-06-27 |
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.6 to be dropped in pip 22.0: #10461 (comment).
We can also remove a bit of redundant Python 2 code.