Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disallow installing or building / #10533

Closed
1 task done
graingert opened this issue Oct 2, 2021 · 6 comments
Closed
1 task done

disallow installing or building / #10533

graingert opened this issue Oct 2, 2021 · 6 comments
Labels
project: setuptools Related to setuptools type: bug A confirmed bug or unintended behavior

Comments

@graingert
Copy link
Contributor

graingert commented Oct 2, 2021

What's the problem this feature will solve?

I used pip install --use-pep517 file:/// and it instantly consumed the last of my disk space making my computer unusable without a reboot and carefully removing the tmp directory

Describe the solution you'd like

Prevent installing / or any other source tree containing its build destination

Alternative Solutions

Like I could just not try to do silly things like pip install /

Additional context

NA

Code of Conduct

@graingert graingert added S: needs triage Issues/PRs that need to be triaged type: feature request Request for a new feature labels Oct 2, 2021
@pfmoore
Copy link
Member

pfmoore commented Oct 2, 2021

This is fixed by --use-feature=in-tree-build which will be the default in the next pip release. The issue is because we (currently) create a copy of the source directory when building.

Solution: don't do that until pip 21.3 is released 😉

@pfmoore pfmoore added type: bug A confirmed bug or unintended behavior and removed type: feature request Request for a new feature S: needs triage Issues/PRs that need to be triaged labels Oct 2, 2021
@pfmoore
Copy link
Member

pfmoore commented Oct 2, 2021

(No "Resolution: already fixed using Guido's time machine" label)

@pradyunsg
Copy link
Member

I believe that @sbidoul has, indeed, returned the keys to the time machine.

@graingert
Copy link
Contributor Author

graingert commented Oct 2, 2021

I think it's still a problem with the --use-feature=in-tree-build eg stuff getting copied into the .whl although it won't be as instantly deleterious. I'll check it when I get to a machine I can try it with

@pfmoore
Copy link
Member

pfmoore commented Oct 2, 2021

At this point we're getting to the "don't pass a source tree that you haven't checked and validated to pip" situation. After all, I could just as easily write a valid setup.py that copied the whole of your hard disk into the wheel (or for that matter, to my website!)

I honestly don't feel that this line of discussion is very productive, so I'm going to drop it here.

@pradyunsg pradyunsg added the project: setuptools Related to setuptools label Oct 2, 2021
@pradyunsg
Copy link
Member

Closing this:

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
project: setuptools Related to setuptools type: bug A confirmed bug or unintended behavior
Projects
None yet
Development

No branches or pull requests

3 participants