Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define minimal pyparsing version #103

Merged
merged 1 commit into from
Apr 7, 2017

Conversation

xavfernandez
Copy link
Member

closes #91

@xavfernandez
Copy link
Member Author

@dstufft: Ok, you've got the choice between this PR or #93 depending on if you wish a changelog or not ^^

@xavfernandez
Copy link
Member Author

Or even going with something like #98:

--- a/packaging/requirements.py
+++ b/packaging/requirements.py
@@ -56,7 +56,7 @@ _VERSION_SPEC.setParseAction(lambda s, l, t: t._raw_spec or '')
 VERSION_SPEC = originalTextFor(_VERSION_SPEC)("specifier")
 VERSION_SPEC.setParseAction(lambda s, l, t: t[1])

-MARKER_EXPR = originalTextFor(MARKER_EXPR())("marker")
+MARKER_EXPR = originalTextFor(MARKER_EXPR(None))("marker")
 MARKER_EXPR.setParseAction(
     lambda s, l, t: Marker(s[t._original_start:t._original_end])
 )

Which should/could work with pyparsing==2.0.1

@dstufft dstufft merged commit 90403b4 into pypa:master Apr 7, 2017
@xavfernandez xavfernandez deleted the minimum_pyparsing_version branch March 28, 2020 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatible version of pyparsing not restricted in setup.py
2 participants