Support "macosx_10_9_universal2" wheels #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or later The arm64 part of the binary only supports macOS 11 or later because that's the first release of macOS for arm64, but having a wheel where the x86_64 part supports an earlier version of the OS is useful to have. This matches the universal2 installer on python.org
|
/cc @lawrence-danna-apple @brettcannon I guess. |
|
BTW. The first two commits are by an unknown users, that's me on a new laptop. I forgot to check my git settings beforehand. If that's a problem I can recreate the PR. |
lawrence-danna-apple
approved these changes
Dec 31, 2020
7 tasks
brettcannon
approved these changes
Jan 4, 2021
3 tasks
This was referenced Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #379 and adds support for "universal2" wheels where the macOS version is lower than macOS 11.
The first commit ensures that tests pass on macOS 11.1 and is technically unrelated to the issue.