Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single-sourcing the package version: Add instructions for setuptools using pyproject.toml #1167

Merged
merged 5 commits into from
Dec 6, 2022
Merged

Single-sourcing the package version: Add instructions for setuptools using pyproject.toml #1167

merged 5 commits into from
Dec 6, 2022

Conversation

justinchuby
Copy link
Contributor

@justinchuby justinchuby commented Nov 21, 2022 •
edited
Loading

On the Single-sourcing the package version page, the newer pyproject.toml is not mentioned for setuptools. This adds a clean way of configuring it in pyproject.toml.

@venthur
Copy link
Contributor

venthur commented Dec 5, 2022

Thanks for spotting and fixing the issue!

@bhrutledge bhrutledge enabled auto-merge (squash) December 6, 2022 12:59
@bhrutledge bhrutledge merged commit 0b2d1bc into pypa:main Dec 6, 2022
@justinchuby justinchuby deleted the patch-1 branch December 6, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhrutledge bhrutledge bhrutledge approved these changes

@abravalheri abravalheri Awaiting requested review from abravalheri

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@justinchuby @venthur @bhrutledge