Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about redundant license field if classifier is present #465

Closed
merwok opened this issue Nov 3, 2021 · 4 comments
Closed

Warn about redundant license field if classifier is present #465

merwok opened this issue Nov 3, 2021 · 4 comments

Comments

@merwok
Copy link
Contributor

merwok commented Nov 3, 2021

Projects are supposed to use a license classifier, if one exists for their license.
The license field is meant to be free-form text to specify a non-standard license or to add details to a classifier (to specify Other :: Proprietary, or maybe to add patent note for example).
Many projects needlessly define license, flit could warn about that when it validates metadata.

@takluyver
Copy link
Member

I've also noticed that a lot of people set both, or prefer the license field. But at some point, it seems likely that it will be possible to express richer & more detailed license information in the license field as SPDX expressions (PEP 639). So I don't want to push people too much towards classifiers for license information, when we might be pushing them in another direction in a few months.

@Conchylicultor
Copy link

A similar point could be made for the requires-python field.

With poetry, "Programming Language :: Python :: 3", and "License :: OSI Approved :: Apache Software License" classifiers are automatically set.

Maybe Flit could do the same ?

This would push people to use license= and requires-python fields rather than classifiers.

@pradyunsg
Copy link
Member

pradyunsg commented Jan 2, 2022

I don't think we should add such a warning for license. Rather, I think that we should not do anything here right now. See pypa/trove-classifiers#17, which is about how existing license classifiers are not sufficeint.

Once PEP 639 is accepted, we'll deprecate both the license classifiers as well as the regular table-based license fields. Basically, we're going to get license = "MIT" once that happens and will want to push users to adopt that.

@merwok
Copy link
Contributor Author

merwok commented Jan 2, 2022

Let’s see where the PEP goes.

@merwok merwok closed this as completed Jan 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants