Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCompiler.has_function: Do not fail if self.outputdir is set #65

Merged
merged 3 commits into from
Nov 9, 2021
Merged

CCompiler.has_function: Do not fail if self.outputdir is set #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ccd3407
distutils/ccompiler.py (CCompiler.has_function): Do not fail if self.…
mkoeppe Nov 7, 2021
b0db51d
distutils/tests/test_unixccompiler.py (UnixCCompilerTestCase.test_has…
mkoeppe Nov 9, 2021
e59011a
Use simple expression for resolution of outputdir.
jaraco Nov 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion distutils/ccompiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -802,7 +802,7 @@ def has_function(self, funcname, includes=None, include_dirs=None,
except (LinkError, TypeError):
return False
else:
os.remove("a.out")
os.remove(os.path.join(self.output_dir or '', "a.out"))
finally:
for fn in objects:
os.remove(fn)
Expand Down
7 changes: 7 additions & 0 deletions distutils/tests/test_unixccompiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,13 @@ def gcvs(*args, _orig=sysconfig.get_config_vars):
sysconfig.customize_compiler(self.cc)
self.assertEqual(self.cc.linker_so[0], 'my_ld')

def test_has_function(self):
# Issue https://github.com/pypa/distutils/issues/64:
# ensure that setting output_dir does not raise
# FileNotFoundError: [Errno 2] No such file or directory: 'a.out'
self.cc.output_dir = 'scratch'
self.cc.has_function('abort', includes=['stdlib.h'])


def test_suite():
return unittest.makeSuite(UnixCCompilerTestCase)
Expand Down