Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove a couple of things pylint is unhappy about #2027

Merged
merged 1 commit into from
Oct 2, 2024
Merged

chore: remove a couple of things pylint is unhappy about #2027

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion cibuildwheel/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,6 @@ def get_python_configurations(
def build(self, options: Options, tmp_path: Path) -> None: ...


# pylint: disable-next=inconsistent-return-statements
def get_platform_module(platform: PlatformName) -> PlatformModule:
if platform == "linux":
return cibuildwheel.linux
Expand Down
7 changes: 3 additions & 4 deletions cibuildwheel/options.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,6 @@ def _resolve_cascade(
return result


# pylint: disable-next=inconsistent-return-statements
def _apply_inherit_rule(
before: str | None, after: str, rule: InheritRule, option_format: OptionFormat | None
) -> str:
Expand All @@ -329,10 +328,10 @@ def _apply_inherit_rule(

if rule == InheritRule.APPEND:
return option_format.merge_values(before, after)
elif rule == InheritRule.PREPEND:
if rule == InheritRule.PREPEND:
return option_format.merge_values(after, before)
else:
assert_never(rule)

assert_never(rule)


def _stringify_setting(
Expand Down