Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building pp37-win32 wheel fails - Outdated PyPy 3.7 download link #1041

Closed
Saransh-cpp opened this issue Feb 28, 2022 · 3 comments
Closed

Building pp37-win32 wheel fails - Outdated PyPy 3.7 download link #1041

Saransh-cpp opened this issue Feb 28, 2022 · 3 comments

Comments

@Saransh-cpp
Copy link

Description

Reference workflow - https://downloads.python.org/pypy/pypy3.7-v7.3.3-win32.zip

Building pp37-win32 wheel is failing on Windows 32bit as cibuildwheel is trying to download PyPy 3.7 through an outdated link (an older version) - https://downloads.python.org/pypy/pypy3.7-v7.3.3-win32.zip - which is no longer active. The active link is - https://downloads.python.org/pypy/pypy3.7-v7.3.8-win64.zip

Can this be fixed from our end or is this a core cibuildwheel issue?

Build log

https://downloads.python.org/pypy/pypy3.7-v7.3.3-win32.zip

CI config

https://github.com/Saransh-cpp/PyBaMM/blob/failing-build-wheels/.github/workflows/build_wheels.yml

@henryiii
Copy link
Contributor

PyPy dropped Windows 32 bit support in version 7.3.4 (when they added 64-bit support, actually). Do you actually need 32-bit Windows PyPy wheels? Also, wasn't expecting the link to stop working, even it it's a bit older (and especially as the final supported version). CC @mattip.

@mattip
Copy link
Contributor

mattip commented Mar 1, 2022

@Saransh-cpp
Copy link
Author

Thank you for all the help, @henryiii and @mattip! Yes, the link is up again and the workflows are passing. We will definitely look into removing 32-bit windows wheels of PyPy in PyBaMM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants