Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPATH not properly set when using -L option #232

Closed
niess opened this issue Mar 30, 2020 · 1 comment
Closed

RPATH not properly set when using -L option #232

niess opened this issue Mar 30, 2020 · 1 comment

Comments

@niess
Copy link

niess commented Mar 30, 2020

Hello,

thank your for this great tool :)

This issue is related to #90 I guess. With the latest release when using using auditwheel -L libs the libs are indeed put under libs yet the RPATH of binaries are set to ${WHEELNAME}libs.

@niess
Copy link
Author

niess commented Mar 30, 2020

My bad. I got confused by a previous install and the new behaviour for storing libs. I was expecting files inside the package. Actually the libs are properly installed but in ../${WHEELNAME}libs, i.e. out of the package. This is the new intended behaviour I guess? So It should be fine. Also I can recover the previous behaviour by adding a leading '/' to the -L option.

Note however that this is not documented in the CLI help which is somehow confusing. The help states:

  -L LIB_SDIR, --lib-sdir LIB_SDIR
                        Subdirectory in packages to store copied libraries.
                        (default: ".libs")

I am not a native English speaker but for me "in package" means inside.

So I would rename this issue to "Change in -L option not documented".

@niess niess closed this as completed Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant