Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimum ABI warning #101

Closed
wsfulton opened this issue Jul 17, 2024 · 5 comments · Fixed by #103
Closed

Minimum ABI warning #101

wsfulton opened this issue Jul 17, 2024 · 5 comments · Fixed by #103
Assignees

Comments

@wsfulton
Copy link
Contributor

When running:

abi3audit --assume-minimum-abi3 3.4 --report -o example_abi3_report.json _example.abi3.so

I see:

[07:32:43] WARNING  no wheel to infer abi3 version from; assuming (3.4)                                                                                                                      _object.py:53
[07:32:44] 💁 _example.abi3.so: 1 extensions scanned; 0 ABI version mismatches and 0 ABI violations found                                                                                                 

It seems that this warning is pointless as I tell abi3audit to use a .so instead of a wheel and I tell it the minimum version to assume. Is either of these possible:

  1. Can the warning be removed when using --assume-minimum-abi3 ?
  2. Add in a warning control system for named/numbered warnings in the same way that compiler warnings can be individually turned on and off, like the -W family of options in gcc?
@woodruffw
Copy link
Member

IMO it'd be useful to keep around as a DEBUG and not a WARNING (since it helps me root-cause user reports), but I agree that it's pointless as a warning when the user explicitly sets --assume-minimum-abi3.

Would you be interested in sending a PR for that? Otherwise I'll likely get to it today or tomorrow.

@wsfulton
Copy link
Contributor Author

I might just leave this to you if you don't mind as I don't quite understand if you'd prefer a warning instead of debug when --assume-minimum-abi3 is actually set.

@woodruffw
Copy link
Member

if you'd prefer a warning instead of debug when --assume-minimum-abi3 is actually set.

Yeah, I was thinking an unconditional DEBUG (since it's still useful information to have when debugging). But I'll do this one.

@woodruffw
Copy link
Member

Done with #103. Let me know if you'd like a release for this, otherwise I'm likely to do it when the next round of feature changes happens!

@wsfulton
Copy link
Contributor Author

Thanks. No rush for you to make a release from my side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants