Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quality preferred not displaying #6453

Closed
jxer opened this issue Mar 31, 2019 · 2 comments
Closed

quality preferred not displaying #6453

jxer opened this issue Mar 31, 2019 · 2 comments
Labels
Bug Confirmed Frontend

Comments

@jxer
Copy link

jxer commented Mar 31, 2019

quality preferred no longer displaying, 2 servers confirmed having same issue

https://i.imgur.com/b1EueoQ.png

Branch: master
Commit: b34f1df
Version: 0.3.1
@triage-new-issues triage-new-issues bot added the triage Untriaged issue label Mar 31, 2019
@sharkykh sharkykh added Bug Confirmed Frontend and removed triage Untriaged issue labels Apr 1, 2019
@sharkykh
Copy link
Contributor

sharkykh commented Apr 1, 2019

can confirm.

Medusa/themes-default/slim/src/components/show-header.vue

Line 147 in 9e9fb07

<tr v-if="!getPreset(combineQualities(show.config.qualities.allowed)).length > 0 && combineQualities(show.config.qualities.preferred).length > 0">

I think

- combineQualities(show.config.qualities.preferred).length > 0
+ combineQualities(show.config.qualities.preferred) > 0

as combineQualities returns a number and not an array like getPreset does

@p0psicles p0psicles mentioned this issue Apr 1, 2019
Merged
3 tasks
@medariox
Copy link
Contributor

medariox commented Apr 1, 2019

Fixed with #6455

@medariox medariox closed this as completed Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Confirmed Frontend
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@medariox @sharkykh @jxer