Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WARNING badge repeatedly lit up on SHOWQUEUE-UPDATE spurious IMDbPie "error" #10571

Closed
mmhere opened this issue May 16, 2022 · 5 comments
Closed
Labels

Comments

@mmhere
Copy link

mmhere commented May 16, 2022

Seems like this could be log.info() instead of log.warning(). On every nightly show update, the following appears in the log; because it is a WARNING the tools pulldown badge is always lit with warnings every morning. This makes the badge less useful. Since the badge is always lit up, you don't know when there are actual warnings that might require your attention.

2022-05-16 02:26:32 DEBUG    SHOWQUEUE-UPDATE :: [e4870f8] Generating default search template for show Kiss Sixth Sense, creating template %SN S%0SE%0E, title Kiss Sixth Sense, season -1
2022-05-16 02:26:32 DEBUG    SHOWQUEUE-UPDATE :: [e4870f8] Generating default search template for show Kiss Sixth Sense, creating template %SN S%0SE%0E, title Kiss Sixth Sense, season -1
2022-05-16 02:26:32 DEBUG    SHOWQUEUE-UPDATE :: [e4870f8] 409595: Retrieving show info from IMDb
2022-05-16 02:26:32 DEBUG    SHOWQUEUE-UPDATE :: [e4870f8] 409595: Loading show info from IMDb with ID: tt000None
2022-05-16 02:26:32 WARNING  SHOWQUEUE-UPDATE :: [e4870f8] 409595: IMDbPie error while loading show info: invalid imdb id
2022-05-16 02:26:32 DEBUG    SHOWQUEUE-UPDATE :: [e4870f8] 409595: IMDb didn't return any info for tt000None, skipping update.
2022-05-16 02:26:32 DEBUG    SHOWQUEUE-UPDATE :: [e4870f8] 409595: Saving new IMDb show info to database

Note the surrounding context describing the show "Kiss Sixth Sense" that is involved.

I did a quick hack in .../medusa//tv/series.py (on line 1692 of master branch) to simply change it from log.warning() to log.info().

@mmhere
Copy link
Author

mmhere commented May 16, 2022

Apologies, I haven't done a pull request ("patch"?) here before, so a single word change seems like [for me at least] it is overkill to learn how to do a pull request ("patch"?) and then probly screw it up on my part. (Then have an extra branch sitting around in my environment just for the one word change... A branch I have to later nuke, which has always seemed quite tedious in github.) Again, apologies.

@p0psicles
Copy link
Contributor

Nah this is some kind of bug Loading show info from IMDb with ID: tt000None
That shouldn't happen.

From which indexer has this show been added?

@p0psicles p0psicles added the Bug label May 17, 2022
@mmhere
Copy link
Author

mmhere commented May 17, 2022

The indexer for that show (at the time of adding it to Medusa's DB) was thetvdb

@p0psicles
Copy link
Contributor

So at the time - i suspect - that show didn't have an imdb added in tvdb. But it has now. So I can't reproduce it for that show now.
Maybe you could help me find a show on tvdb that doesn't have the imdb yet.

@mmhere
Copy link
Author

mmhere commented May 28, 2022

I don't have an example of another show that lacks an imdb page. I concur with your assessment. That is a bit of an obscure show, and new at the time, so probly the exception was imdb saying "I dunno?" Good that it would be handled now -- thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants