Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Episode Management appears to be broken #10160

Closed
siconic opened this issue Dec 10, 2021 · 11 comments
Closed

Episode Management appears to be broken #10160

siconic opened this issue Dec 10, 2021 · 11 comments
Assignees

Comments

@siconic
Copy link

siconic commented Dec 10, 2021

When trying to mass change the status of episodes, it appears that there is nothing occurring.

Manage -> Episode Status Management -> Manage Episodes with Status "Snatched" - > Set Checked Shows/Episodes to "Failed"

After following that process, the screen goes blank, and no episodes are marked as failed. It appears to do nothing, and the logs do not reveal anything either. The shows never get added to the "Failed Episodes" list and do not trigger a search.

System Info:
Branch: master
Commit: f35a19d
Version: 0.5.20
Database: 44.18
Python Version: 3.7.8 (default, Aug 8 2020, 01:18:05) [Clang 8.0.0 (tags/RELEASE_800/final 356365)]
SSL Version: OpenSSL 1.0.2o-freebsd 27 Mar 2018
OS: FreeBSD-12.2-RELEASE-p10-amd64-64bit-ELF
Timezone: EST

@siconic
Copy link
Author

siconic commented Dec 27, 2021

Do you need more information? I have not seen any status update or comments. I will be applying the latest update today and will report if there is a change.

@p0psicles p0psicles self-assigned this Dec 27, 2021
@siconic
Copy link
Author

siconic commented Dec 28, 2021

Update did not resolve.

Manage -> Failed downloads, shows no results.

Setting checked episodes to failed does not add them to the failed list.

@p0psicles
Copy link
Contributor

p0psicles commented Dec 30, 2021

Only the failed download handling process is allowed to change a status to failed. As at that time more is done then just changing the status. It's also logging the last failed/attempted snatch. Something that it can't do when just changing the status.

I can create a PR and allow for it to change to Failed. I'm just not sure if that won't cause other issues.

@siconic
Copy link
Author

siconic commented Dec 30, 2021

Only the failed download handling process is allowed to change a status to failed. As at that time more is done then just changing the status. It's also logging the last failed/attempted snatch. Something that it can't do when just changing the status.

I can create a PR and allow for it to change to Failed. I'm just not sure if that won't cause other issues.

It used to work about 6 weeks ago. Maybe we are talking about different things?

Clicking here takes you to "snatched" episode management:
image

Setting "Set Check shows/episodes to Failed" would mark them as failed and trigger a backlog search.
image

I used to see immediate results in SAB as the new versions were snatched and those marked "Failed" would end up in the failed downloads DB, but now they do not get added to the failed downloads DB, a backlog search is not triggered, and they never get re-searched.
image

So I guess I don't follow what you are trying to tell me, since this WAS something that was fully functional, and somehow stopped working. It would certainly have to suck to go into each Show and find all the "Snatched" episodes, and manually mark them all as failed.

@p0psicles
Copy link
Contributor

If this is a regression I'll make sure to fix it. I'll check it out

@p0psicles
Copy link
Contributor

p0psicles commented Jan 1, 2022

Could you try running the branch: feature/fix-mass-update-status and report if this is fixed for you?

@p0psicles
Copy link
Contributor

should be fixed in develop branch

@siconic
Copy link
Author

siconic commented Jan 3, 2022

While this does now change them to "Failed" they do not trigger a search. Again, there was a whole process that worked and is now broken. Several weeks ago, if you set the status to failed, a popup would ask "Would you like to search" or maybe it was "Would you like to trigger a backlog search". I cant remember the exact verbiage, but this feature would then run a search for failed episodes.

The current changes you made to episode.py does not seem to trigger the search.

@siconic
Copy link
Author

siconic commented Jan 3, 2022

Additional Info:

I directly modified the episode.py file. It could be there were other edits you had made, that have not been committed yet. Let me know, I didnt want to change my branch, just wanted to get this working.

*EDIT: I edited the py file using VIM since I am using a FreeBSD jail to host my PyMedusa (on a TrueNAS system), if that makes any difference.

@p0psicles
Copy link
Contributor

@siconic
Copy link
Author

siconic commented Jan 4, 2022

OK, I will wait until it is merged, I may have something improper in my formatting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants