Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MediaTransformation and MediaConfigList in example notebook #985

Open
wd60622 opened this issue Aug 29, 2024 · 4 comments
Open

MediaTransformation and MediaConfigList in example notebook #985

wd60622 opened this issue Aug 29, 2024 · 4 comments
Labels
docs Improvements or additions to documentation MMM

Comments

@wd60622
Copy link
Contributor

wd60622 commented Aug 29, 2024

Following #968, these new classes can be used in an example notebook. Likely the components notebook

@wd60622 wd60622 added docs Improvements or additions to documentation MMM labels Aug 29, 2024
@Ishaanjolly
Copy link
Contributor

@wd60622 Can i create an example notebook? I don't see a notebooks directory. Where may this example notebook be located?

@wd60622
Copy link
Contributor Author

wd60622 commented Sep 24, 2024

Hi @Ishaanjolly,
The mmm_components notebook might be a good location for this. That has been a catch all for various building blocks of the MMMs.

@Ishaanjolly
Copy link
Contributor

Cool, can I try to add something then? maybe you could give a review for my PR?

@wd60622
Copy link
Contributor Author

wd60622 commented Sep 24, 2024

Cool, can I try to add something then? maybe you could give a review for my PR?

Yes, feel free to adjust that notebook and make a PR. Some of the existing work might need to be rewritten. Feel free to adjust where makes sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation MMM
Projects
None yet
Development

No branches or pull requests

2 participants